feat(kuma-cp) endpoints for fetch resources from all meshes #657
Conversation
| @@ -15,26 +15,28 @@ import ( | |||
| rest_errors "github.com/Kong/kuma/pkg/core/rest/errors" | |||
| ) | |||
|
|
|||
| type overviewWs struct { | |||
| type dataplaneOverviewEndpoints struct { | |||
There was a problem hiding this comment.
Why *Endpoint instead of *Ws? And I guess it should be consistent with the file name which is *_ws.go
There was a problem hiding this comment.
Ws is WebService from go-restful. It feel like endpoints is better name here since we add endpoints to existing webservice.
There was a problem hiding this comment.
I didn't want to rename files to avoid conflicts with community PR as well as for it to be easier to review, but since I've got +1 on this then let me change it.
| func (r *overviewWs) AddToWs(ws *restful.WebService) { | ||
| ws.Route(ws.GET("/{mesh}/dataplanes+insights/{name}").To(r.inspectDataplane). | ||
| func (r *dataplaneOverviewEndpoints) addFindEndpoint(ws *restful.WebService, pathPrefix string) { | ||
| ws.Route(ws.GET(pathPrefix+"/dataplanes+insights/{name}").To(r.inspectDataplane). | ||
| Doc("Inspect a dataplane"). | ||
| Param(ws.PathParameter("name", "Name of a dataplane").DataType("string")). | ||
| Param(ws.PathParameter("mesh", "Name of a mesh").DataType("string")). |
There was a problem hiding this comment.
Should we delete this Param?
There was a problem hiding this comment.
Or it is expected to be equal to empty string for "all mesh fetch"?
There was a problem hiding this comment.
It is used endpoints.addListEndpoint(ws, "/meshes/{mesh}")
There was a problem hiding this comment.
and it is expected to be empty string on the endpoints fetched resources from all meshes
| } | ||
| } | ||
|
|
||
| type resourceEndpoints struct { |
There was a problem hiding this comment.
And probably here makes sense to rename the file to resourse_endpoint?
jakubdyszkiewicz
force-pushed
the
feat/endpoints-for-all-entities
branch
from
f7bd7bc
to
7c88beb
Compare
Summary
Endpoints for fetching resources from all meshes.
Ex.
/traffic-permissionsnext to/meshes/{mesh}/traffic-permissionsendpoint