feat(config): improve configurability #6583

slonka · 2023-04-21T11:24:29Z

Make it possible for parent projects to configure more options. Wire up context in places that it's missing.

Checklist prior to review

Link to relevant issue as well as docs and UI issues -- related to an issue from a parent project
This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
Tests (Unit test, E2E tests, manual test on universal and k8s) --
Do you need to update UPGRADE.md? -- no, backwards compatible
Does it need to be backported according to the backporting policy? -- nope
Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests? -- yes

Signed-off-by: slonka <slonka@users.noreply.github.com>

…ponents Signed-off-by: slonka <slonka@users.noreply.github.com>

Signed-off-by: slonka <slonka@users.noreply.github.com>

pkg/config/multizone/multicluster.go

pkg/core/resources/manager/cache.go

pkg/kds/v2/reconcile/reconciler.go

pkg/plugins/authn/api-server/tokens/plugin.go

pkg/plugins/resources/postgres/pgx_store.go

pkg/util/iterator/context.go

app/kuma-cp/cmd/run.go

Signed-off-by: slonka <slonka@users.noreply.github.com>

…arent context Signed-off-by: slonka <slonka@users.noreply.github.com>

…outside Signed-off-by: slonka <slonka@users.noreply.github.com>

Signed-off-by: slonka <slonka@users.noreply.github.com>

… of context Signed-off-by: slonka <slonka@users.noreply.github.com>

Signed-off-by: slonka <slonka@users.noreply.github.com>

go.mod

pkg/core/resources/store/options.go

pkg/defaults/components.go

pkg/metrics/store/counter.go

pkg/multitenant/hashing.go

pkg/plugins/authn/api-server/tokens/plugin.go

pkg/plugins/bootstrap/k8s/plugin.go

pkg/multitenant/pgx.go

pkg/plugins/resources/postgres/plugin.go

Co-authored-by: Charly Molter <charly@molter.io> Signed-off-by: Krzysztof Słonka <slonka@users.noreply.github.com>

Signed-off-by: slonka <slonka@users.noreply.github.com>

…/store Signed-off-by: slonka <slonka@users.noreply.github.com>

Signed-off-by: slonka <slonka@users.noreply.github.com>

…o not have dep cycle Signed-off-by: slonka <slonka@users.noreply.github.com>

Signed-off-by: slonka <slonka@users.noreply.github.com>

lahabana

LGTM just nits around go idiomatic interfaces and a point around the signing key management (I think we should push this problem for later like we did for metrics)

pkg/defaults/components.go

pkg/kds/v2/reconcile/reconciler.go

pkg/multitenant/hashing.go

pkg/multitenant/multitenant.go

pkg/plugins/resources/postgres/config/customization.go

pkg/multitenant/hashing.go

pkg/plugins/resources/postgres/pgx_store.go

Signed-off-by: slonka <slonka@users.noreply.github.com>

slonka added 16 commits April 18, 2023 14:49

feat(config): add more configuration options

d0957d7

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): wire up context to a lot of components

3c45854

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): wire up context to a validation and other components

4041b0c

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): wire up more context

ed0e739

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): add todo

52f18ad

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): add metadata decoration

80c4414

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): make it possible to customize cache keys

cc93b8d

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): tmp

a9dbae1

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): race condition gone

99b592c

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): cleanup

e205705

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): add custom iterator around multiple around multiple com…

4ed94a3

…ponents Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): add iterator to finalizer

f8d214f

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): make check pass

69e7a58

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): clean up

eeb0894

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): clean up

78b304e

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): revert temporary change

305b749

Signed-off-by: slonka <slonka@users.noreply.github.com>

slonka added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Apr 21, 2023

slonka added 2 commits April 21, 2023 13:49

feat(config): make check pass

c7b4a92

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): fix unit tests

0844688

Signed-off-by: slonka <slonka@users.noreply.github.com>

lahabana reviewed Apr 21, 2023

View reviewed changes

slonka added 10 commits April 21, 2023 14:57

feat(config): fix e2e test

b21cabe

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): make check pass

73ed119

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): rewrite components to use context iterator

51559bf

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): revert mesh manager

67cd671

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): make it possible for the custom iterator to receive a p…

ce6bdaa

…arent context Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): make it possible to call one off components logic from …

3570d0b

…outside Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): fix clusterid creator

7841898

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): make status sink cache context aware

e65f4fb

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): make check pass

48d5dc2

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): change zone insight cache to rely on string key instead…

ff0da06

… of context Signed-off-by: slonka <slonka@users.noreply.github.com>

slonka added 4 commits April 25, 2023 19:00

feat(config): return empty tenant id

3ba6610

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): add default getters to tests

71c7624

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): replace some nulls

23f700c

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): add plugins to k8s

af94326

Signed-off-by: slonka <slonka@users.noreply.github.com>

slonka force-pushed the improve-configurability branch from dbfa0fa to af94326 Compare April 25, 2023 17:50

slonka added 2 commits April 25, 2023 20:23

feat(config): add plugins to bootstrap

2efae64

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): fix npe

c2d4a4c

Signed-off-by: slonka <slonka@users.noreply.github.com>

lahabana reviewed Apr 25, 2023

View reviewed changes

slonka and others added 4 commits April 26, 2023 06:32

Update go.mod

079de81

Co-authored-by: Charly Molter <charly@molter.io> Signed-off-by: Krzysztof Słonka <slonka@users.noreply.github.com>

feat(config): fix go mod

021e00a

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): rename suffix to KeyFromContext

ea546eb

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): add issue comment

f6e7e35

Signed-off-by: slonka <slonka@users.noreply.github.com>

slonka mentioned this pull request Apr 26, 2023

Make counter metrics tenant aware #6622

Closed

slonka added 10 commits April 26, 2023 06:52

feat(config): revert metrics

962d0e1

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): change KeyFromContext to have empty suffix

d39a061

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): remove multitenant/hashing dependency on core/resources…

d152b14

…/store Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): change tenant to be tenantFn

a21df10

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): use only one hashing function

1e47fad

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): move pgx pool configuration customisation

45dfb86

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): wire in config customisation properly

5d7071b

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): rename fields

429cb16

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): move postgres config customisation to separate folder t…

f87fd4e

…o not have dep cycle Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): rename variables to be consistent

cbe306c

Signed-off-by: slonka <slonka@users.noreply.github.com>

slonka marked this pull request as ready for review April 26, 2023 07:01

lahabana approved these changes Apr 26, 2023

View reviewed changes

slonka added 4 commits April 26, 2023 10:10

feat(config): restore the interface

1f04964

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): tmp fix hasher

61049b5

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): revert defaults component

d2f221e

Signed-off-by: slonka <slonka@users.noreply.github.com>

feat(config): add the hasher comment and rename some variables

2bb9dad

Signed-off-by: slonka <slonka@users.noreply.github.com>

slonka merged commit 3f9294c into kumahq:master Apr 27, 2023
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(config): improve configurability #6583

feat(config): improve configurability #6583

slonka commented Apr 21, 2023 •

edited

lahabana left a comment

feat(config): improve configurability #6583

feat(config): improve configurability #6583

Conversation

slonka commented Apr 21, 2023 • edited

Checklist prior to review

lahabana left a comment

Choose a reason for hiding this comment

slonka commented Apr 21, 2023 •

edited