fix(injector) change local address for probes #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
approved these changes
Apr 6, 2020
lobkovilya
force-pushed
the
fix/probes-local-address
branch
from
a61c2a0
to
ca471fd
Compare
tharun208
pushed a commit
to tharun208/kuma
that referenced
this pull request
Apr 6, 2020
* fix(injector) change local address for probes * fix(injector) fix injector tests * fix(injector) add CHANGELOG
tharun208
pushed a commit
to tharun208/kuma
that referenced
this pull request
Apr 6, 2020
* fix(injector) change local address for probes * fix(injector) fix injector tests * fix(injector) add CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
kuma-dprefuses to work on Kind after updating Envoy up to 1.13.1, current PR fixes that issueReadiness and liveness probes didn't work as expected and failed with:
Readiness probe failed: wget: can't connect to remote host: Connection refused.For some reason,
localhostresolves to127.0.0.1on envoy-alpine 1.12.2 and resolves to::1on further versions.According to envoy source code, admin server listener starts at
0.0.0.0:9901so it binds to IPv4 interface. So in order to avoid ambiguous behavior, makes sense to change localhost to 127.0.0.1