Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tls): remove commonName in certificate generation #6627

Merged
merged 4 commits into from May 3, 2023
Merged

feat(tls): remove commonName in certificate generation #6627

merged 4 commits into from May 3, 2023

Conversation

mmorel-35
Copy link
Contributor

Checklist prior to review

@mmorel-35 mmorel-35 requested review from a team, michaelbeaumont and bartsmykla and removed request for a team April 26, 2023 11:50
@lobkovilya
Copy link
Contributor

Probably we have to outline the places affected by this change:

  • kumactl generate tls-certificate generates certificates without CN
  • autogenerated TLS certificate for kuma-cp (when general.tlsCertFile is not provided) won't have CN

But I'm not sure if this should be mentioned in UPGRADE.md or just CHANGELOG is enough. @bartsmykla @michaelbeaumont what do you think?

Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a mention in UPGRADE.md is appropriate, we just mention that this only affects you if you explicitly rely on the common name being present in generated certs.

UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
mmorel-35 and others added 4 commits May 2, 2023 19:21
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lobkovilya lobkovilya merged commit 0d2590f into kumahq:master May 3, 2023
4 checks passed
@mmorel-35 mmorel-35 deleted the issues/6625 branch May 3, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecating the use of commonName in certificate generation
3 participants