Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump Envoy to v1.26.1 #6638

Merged
merged 2 commits into from May 3, 2023
Merged

chore(deps): bump Envoy to v1.26.1 #6638

merged 2 commits into from May 3, 2023

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Apr 28, 2023 •
edited by lobkovilya

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- update to envoy 1.26 #6553
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: chore(deps): bump Envoy from v1.25.4 to v1.26.2

@michaelbeaumont
chore(deps): bump Envoy to v1.26.1
820f9ea 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Apr 28, 2023
@michaelbeaumont michaelbeaumont marked this pull request as ready for review April 28, 2023 13:03
@michaelbeaumont michaelbeaumont requested review from a team, bartsmykla and lobkovilya and removed request for a team April 28, 2023 13:03
@jakubdyszkiewicz
Copy link
Contributor

Does it have Ilya's fix?

https://www.envoyproxy.io/docs/envoy/v1.26.1/version_history/v1.26/v1.26.1
https://github.com/envoyproxy/envoy/commits/v1.26.1

@michaelbeaumont
Copy link
Contributor Author

michaelbeaumont commented May 2, 2023 •
edited

Yep, built with the 1.25 branch of envoy-builds which applied Ilya's patch, which is now merged into main.

@michaelbeaumont michaelbeaumont merged commit 8b5da39 into kumahq:master May 3, 2023
4 checks passed
@michaelbeaumont michaelbeaumont deleted the build/envoy branch May 3, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla bartsmykla approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaelbeaumont @jakubdyszkiewicz @bartsmykla