Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(kumactl) added logging and tracing information #665

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

tharun208
Copy link
Contributor

Feature #628

Summary

Added Logging and Tracing Information for meshes

Full changelog

*Implemented logging and tracing information for meshes

  • added helper functions for getting logging and tracing information and tests
  • updated tests

Issues resolved

Fix #628

@tharun208 tharun208 requested a review from a team April 6, 2020 08:55
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a changelog

pkg/core/resources/apis/mesh/mesh_helpers.go Outdated Show resolved Hide resolved
pkg/core/resources/apis/mesh/mesh_helpers.go Outdated Show resolved Hide resolved
pkg/core/resources/apis/mesh/mesh_helpers.go Outdated Show resolved Hide resolved
@tharun208
Copy link
Contributor Author

should I need to rebase with upstream?

@jakubdyszkiewicz
Copy link
Contributor

yes please

@jakubdyszkiewicz jakubdyszkiewicz merged commit ac4eb3b into kumahq:master Apr 6, 2020
@jakubdyszkiewicz
Copy link
Contributor

thanks for working on this!

@tharun208 tharun208 deleted the feat/#628 branch April 6, 2020 14:41
@subnetmarco
Copy link
Contributor

Thanks @tharun208 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logging information to kumactl get meshes
3 participants