chore(konvoyctl) fixing product name #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
suggested changes
Jul 23, 2019
| @@ -1,7 +1,7 @@ | |||
| # konvoyctl | |||
|
|
|||
| ``` | |||
| Management tool for Konvoy Service Mesh. | |||
There was a problem hiding this comment.
HELP.md is auto-generated.
Instead, you have to:
- change that string in the source code - https://github.com/Kong/konvoy/blob/master/components/konvoy-control-plane/app/konvoyctl/cmd/root.go#L39-L40
- run
make checkto re-generateHELP.md
There was a problem hiding this comment.
Sorry, use make docs instead (it doesn't require extra development tools to be installed)
subnetmarco
force-pushed
the
docs/konvoyctl
branch
2 times, most recently
from
824f8e2
to
1277739
Compare
|
@yskopets I have implemented your suggestion. If |
subnetmarco
force-pushed
the
docs/konvoyctl
branch
from
1277739
to
6b3e689
Compare
subnetmarco
changed the title
|
@subnetmarco define the desired behaviour and we will implement it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor documentation fix.