New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(MADR): MeshTCPRoute proposal #6711
Conversation
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also mention the behavior with respect to the protocol. I guess it should not be possible to apply MeshTCPRoute for HTTP service
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
05e28ea
to
2f31cab
Compare
Apologies for force pushing, but I made a mess with unfortunate rebase by mistake. |
One thing that isn't covered is what happens when both a TCP and an HTTP route match |
That's a good question. Let me figure this out, and update the MADR. |
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com> Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
?> Changelog:
entry here or add aci/
label to run fewer/more tests?