Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(MADR): MeshTCPRoute proposal #6711

Merged
merged 20 commits into from May 17, 2023

Conversation

bartsmykla
Copy link
Contributor

@bartsmykla bartsmykla commented May 9, 2023

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
    • it won't as it's just a MADR
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • no tests as it's just a MADR
  • Do you need to update UPGRADE.md?
    • no need as it's just a MADR
  • Does it need to be backported according to the backporting policy?
    • no need as it's just a MADR
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?
    • no

Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla added kind/docs About docs ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) labels May 9, 2023
@bartsmykla bartsmykla marked this pull request as ready for review May 10, 2023 09:26
@bartsmykla bartsmykla requested review from a team, lobkovilya and lukidzi and removed request for a team May 10, 2023 09:26
Copy link
Contributor

@lobkovilya lobkovilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also mention the behavior with respect to the protocol. I guess it should not be possible to apply MeshTCPRoute for HTTP service

docs/madr/decisions/026-mesh-tcp-route.md Show resolved Hide resolved
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla
Copy link
Contributor Author

Apologies for force pushing, but I made a mess with unfortunate rebase by mistake.

@lahabana
Copy link
Contributor

One thing that isn't covered is what happens when both a TCP and an HTTP route match

@bartsmykla
Copy link
Contributor Author

One thing that isn't covered is what happens when both a TCP and an HTTP route match

That's a good question. Let me figure this out, and update the MADR.

@lahabana lahabana changed the title docs(MeshTCPRoute): add policy MADR docs(MADR): MeshTCPRoute proposal May 12, 2023
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla enabled auto-merge (squash) May 17, 2023 12:11
@bartsmykla bartsmykla merged commit 57e45b6 into kumahq:master May 17, 2023
4 checks passed
@bartsmykla bartsmykla deleted the docs/meshtcproute-madr branch May 17, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) kind/docs About docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design MeshTCPRoute
5 participants