fix: reduce Prometheus scrape_interval to work with Kong Prometheus plugin #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devadvocado
force-pushed
the
interval-change
branch
2 times, most recently
from
53a45c8
to
1d8d9e2
Compare
|
I need more context. Why does this change fix stuff? |
|
Updated the PR summary with explanation. |
|
I think 1m was the default value from prometheus helm chart. Please add a changelog |
devadvocado
changed the title
|
Please rebase to master @devadvocado to fix the CI |
devadvocado
force-pushed
the
interval-change
branch
from
6d76fb5
to
bb1cfaa
Compare
devadvocado
force-pushed
the
interval-change
branch
from
bb1cfaa
to
20c880a
Compare
|
rebased onto master to resolve conflict on CHANGELOG file |
jakubdyszkiewicz
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the Prometheus scrape_interval to 10s to support the Kong Gateway Prometheus plugin. Scrape interval for the Kong gateway Prometheus proxy doesn't work well if the intervals are too far apart, so the easiest fix is to just lower the interval. Default Prometheus setting for the interval is 15s so no reason to have it at set to 1 minute to begin with.