feat(helm): enable NodePort customization #6770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbeaumont
changed the title
mmorel-35
commented
May 16, 2023
mmorel-35
changed the title
mmorel-35
requested review from
a team,
michaelbeaumont and
jakubdyszkiewicz
and removed request for
a team
mmorel-35
commented
May 16, 2023
app/kumactl/cmd/install/testdata/install-control-plane.dump-values.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks @mmorel-35 ! Can we introduce just NodePort customization initially in this PR? I think typically it's not necessary to customize the ports of Services since there's a new ClusterIP allocated for every Service but we can introduce if it's requested later.
app/kumactl/cmd/install/testdata/install-control-plane.dump-values.yaml
Outdated
Show resolved
Hide resolved
mmorel-35
changed the title
app/kumactl/cmd/install/testdata/install-control-plane.dump-values.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
|
Thanks @mmorel-35 !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?