Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MeshHTTPRoute): only configure HTTP outbounds or with an explicit matching rule #6876

Merged
merged 2 commits into from May 31, 2023

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented May 30, 2023

Closes: #6860

Checklist prior to review

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont marked this pull request as ready for review May 30, 2023 11:49
@michaelbeaumont michaelbeaumont requested review from a team, slonka, lobkovilya and bartsmykla and removed request for a team and slonka May 30, 2023 11:49
@michaelbeaumont michaelbeaumont changed the title fix(MeshHTTPRoute): don't configure everything as HTTP fix(MeshHTTPRoute): only configure HTTP outbounds without an explicit matching rule May 30, 2023
@michaelbeaumont michaelbeaumont changed the title fix(MeshHTTPRoute): only configure HTTP outbounds without an explicit matching rule fix(MeshHTTPRoute): only configure HTTP outbounds or with an explicit matching rule May 30, 2023
@bartsmykla
Copy link
Contributor

@michaelbeaumont I allow myself to merge it, as I want to make sure MeshTCPRoute works as expected with your changes (ref. #6873)

@bartsmykla bartsmykla merged commit 3505dcf into kumahq:master May 31, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusion with MeshHTTPRoute configuring listeners with httpConnectionManager for every outbound
2 participants