Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fea(kumactl) parametrize CNI image #689

Merged
merged 4 commits into from
Apr 20, 2020
Merged

fea(kumactl) parametrize CNI image #689

merged 4 commits into from
Apr 20, 2020

Conversation

lobkovilya
Copy link
Contributor

Summary

Add parameter CNIImage for kumact install control-plane command.
Also pushed image lobkovilya/install-cni:0.5.0-rc1

@lobkovilya lobkovilya requested a review from a team April 20, 2020 11:16
@jakubdyszkiewicz
Copy link
Contributor

Please add also a separate version parameter and lock it with some version of your choice (0.0.1 or whatever).
As long as we don't have this image as a part of CI yet it's better not to correlate it with CP version. If we want to release a new version now we have to remember about pushing the image.

@lobkovilya lobkovilya merged commit 291811b into master Apr 20, 2020
@lobkovilya lobkovilya deleted the feat/cni-image-param branch April 20, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lobkovilya @jakubdyszkiewicz