control-plane: config by yaml and envs #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
suggested changes
Jul 24, 2019
There was a problem hiding this comment.
Can I/Should I separate config location for each feature? For example ApiServerConfig could reside in config.go next to server.go and PostgresStoreConfig could be near postgresResourceStore
Indeed, I would to prefer to see configuration split into pieces.
But instead of putting them next to implementation code, they should remain under pkg/config.
E.g., like it was discussed in #48 (comment)
components/konvoy-control-plane/pkg/plugins/resources/postgres/store_test.go
Outdated
Show resolved
Hide resolved
jakubdyszkiewicz
force-pushed
the
feature/config
branch
from
cf813ac
to
5081494
Compare
yskopets
reviewed
Jul 25, 2019
components/konvoy-control-plane/pkg/config/app/konvoy-cp/config.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/pkg/config/app/konvoy-cp/config.go
Outdated
Show resolved
Hide resolved
yskopets
reviewed
Jul 25, 2019
yskopets
approved these changes
Jul 25, 2019
jakubdyszkiewicz
force-pushed
the
feature/config
branch
from
8c9130c
to
c3e54ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces config by YAML and ENV variables.
First YAML file is loaded, then ENV variables. Env vars can override yaml config.
Config file is not mandatory for Konvoy Control Plane to run, you can configure everything by env vars.
Can I/Should I separate config location for each feature? For example
ApiServerConfigcould reside inconfig.gonext toserver.goandPostgresStoreConfigcould be nearpostgresResourceStoreenvconfigcontains full environment variable name on leaves instead of embedding, since weird behaviour of this lib kelseyhightower/envconfig#148