fix(gateway): don't skip retry policy with retry methods (backport of #6896) #6900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kumahq[bot]](https://avatars.githubusercontent.com/u/67433617?s=60&v=4){kind=small}
1. The logic was wrong - if there is ***NO*** retry policy, we should skip applying retriable methods, not the other way around 2. Before it might crash with nil pointer dereference when we provided httpMethods, but there was no retry policy Signed-off-by: Bart Smykla <bartek@smykla.com>
kumahq
bot
requested review from
a team,
slonka and
jakubdyszkiewicz
and removed request for
a team
bartsmykla
approved these changes
Jun 1, 2023
lukidzi
pushed a commit
that referenced
this pull request
Jun 7, 2023
…6896) (#6900) 1. The logic was wrong - if there is ***NO*** retry policy, we should skip applying retriable methods, not the other way around 2. Before it might crash with nil pointer dereference when we provided httpMethods, but there was no retry policy Signed-off-by: Bart Smykla <bartek@smykla.com> Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic cherry-pick of #6896 for branch release-2.1
Generated by action
cherry-picked commit 87f57df