feat(envoyadmin): support passing kds envoy operations via http proxy #6915
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
The current assumption was that Zone CP connects to one instance of Global CP in order to exchange KDS information as well as execute Envoy Admin operations.
We can see it here we call one
grpc.Dial
and then start streaming services on this TCP connection.However, we recently provided an option to disable TLS on Global CP server which means that you may want to have an HTTP reverse proxy in front of Global CP. In this case, HTTP proxy will loadbalance gRPC streams between all instances of Global CP, which means that the assumption that global instance that's handling KDS == global instance that's handling envoy admin rpc streams is wrong.
To fix this, we need to store an instance that's handling each envoy admin rpc stream.
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests? no