Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(envoyadmin): support passing kds envoy operations via http proxy #6915

Conversation

jakubdyszkiewicz
Copy link
Contributor

Checklist prior to review

The current assumption was that Zone CP connects to one instance of Global CP in order to exchange KDS information as well as execute Envoy Admin operations.
We can see it here we call one grpc.Dial and then start streaming services on this TCP connection.

However, we recently provided an option to disable TLS on Global CP server which means that you may want to have an HTTP reverse proxy in front of Global CP. In this case, HTTP proxy will loadbalance gRPC streams between all instances of Global CP, which means that the assumption that global instance that's handling KDS == global instance that's handling envoy admin rpc streams is wrong.

To fix this, we need to store an instance that's handling each envoy admin rpc stream.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) -- It's quite hard to add E2E for this and it would require implementing it in legacy suite, which we try to avoid.
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? -- no
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests? no

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested review from a team, Automaat and bartsmykla and removed request for a team June 2, 2023 13:06
…bal-behind-proxy

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested review from slonka and removed request for bartsmykla June 5, 2023 07:02
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just trying to wrap my head around the fact that we need to keep separate xds / stats / clusters info. Also should we add an issue to have an e2e tests of this?

api/system/v1alpha1/zone_insight.proto Show resolved Hide resolved
@jakubdyszkiewicz
Copy link
Contributor Author

Also should we add an issue to have an e2e tests of this?

I'm not sure... test for it will be quite costly, we need separate multizone deployment to check this out

@jakubdyszkiewicz jakubdyszkiewicz merged commit fb82406 into kumahq:master Jun 5, 2023
3 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/kds-from-global-behind-proxy branch June 5, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants