Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MeshGateway): add TLS passthrough listeners #6922

Merged
merged 8 commits into from Jun 7, 2023
Merged

feat(MeshGateway): add TLS passthrough listeners #6922

merged 8 commits into from Jun 7, 2023

Conversation

michaelbeaumont
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- TLS listener support #6132
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@michaelbeaumont
feat(MeshGateway): add TLS listeners
c1ab63b 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
chore: generate
8efaa08 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
feat(MeshGateway): validate TLS passthrough
3b85768 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
feat(MeshGateway): add TLS + PASSTHROUGH generation
d408326 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test(MeshGateway): add TLS listener test
325c534 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test(e2e): add TLS options to test-server
cf91c79 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test(e2e): add TLS MeshGateway listener test
a335a10 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
chore: remove useless check
47626a5 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont changed the title feat(MeshGateway): add TLS PASSTHROUGH listeners feat(MeshGateway): add TLS passthrough listeners Jun 6, 2023
@michaelbeaumont michaelbeaumont marked this pull request as ready for review June 6, 2023 10:36
@michaelbeaumont michaelbeaumont requested review from a team, slonka, jakubdyszkiewicz and lobkovilya and removed request for a team June 6, 2023 10:36
lobkovilya
lobkovilya approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@lobkovilya lobkovilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/core/resources/apis/mesh/gateway_validator.go Show resolved Hide resolved
@michaelbeaumont michaelbeaumont merged commit cafd3e4 into kumahq:master Jun 7, 2023
4 checks passed
@michaelbeaumont michaelbeaumont deleted the feat/gateway-tls-passthrough branch June 7, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobkovilya lobkovilya lobkovilya approved these changes

@slonka slonka Awaiting requested review from slonka

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaelbeaumont @lobkovilya