Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(k8s): omit fetching other dataplanes when vips are in the config map #6940

Merged
merged 1 commit into from
Jun 6, 2023
Merged

perf(k8s): omit fetching other dataplanes when vips are in the config map #6940

merged 1 commit into from
Jun 6, 2023

Conversation

jakubdyszkiewicz
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@jakubdyszkiewicz
perf(k8s): omit fetching other dataplanes when vips are in the config…
8e88bea 
… map

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz added the ci/force-publish PR: push artifacts even if we're on a PR (use very carefully) label Jun 6, 2023
@jakubdyszkiewicz jakubdyszkiewicz requested review from a team, lobkovilya and lukidzi and removed request for a team June 6, 2023 13:21
@jakubdyszkiewicz jakubdyszkiewicz added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Jun 6, 2023
@jakubdyszkiewicz jakubdyszkiewicz merged commit 44e42a5 into kumahq:master Jun 6, 2023
10 of 11 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the perf/omit-other-dataplanes branch June 6, 2023 14:58
@lahabana lahabana mentioned this pull request Jun 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Automaat Automaat Automaat approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya

@lukidzi lukidzi Awaiting requested review from lukidzi

Assignees
No one assigned
Labels
ci/force-publish PR: push artifacts even if we're on a PR (use very carefully) ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakubdyszkiewicz @Automaat