feat(kuma-cp) Secrets validation on K8S #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobkovilya
approved these changes
Apr 27, 2020
| @@ -235,3 +235,21 @@ webhooks: | |||
| - UPDATE | |||
| resources: | |||
| - services | |||
| - name: secret.validator.kuma-admission.kuma.io | |||
| failurePolicy: Fail | |||
There was a problem hiding this comment.
The question arose from my merging injector and kuma-cp:
Why injector.failurePolicy is parametrized and by default equals Ignore, unlike all other webhooks, have failurePolicy hardcoded and equal Fail?
There was a problem hiding this comment.
I'm not the original author of injector, but my guess is that we don't want to stop the deployment even if Kuma DP fails to be injected.
jakubdyszkiewicz
force-pushed
the
feat/secrets-k8s-validation
branch
from
364d147
to
af91abc
Compare
jakubdyszkiewicz
force-pushed
the
feat/secrets-k8s-validation
branch
from
af91abc
to
1371789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since Kuma Secrets on K8S can be applied directly using kubectl, we need to validate those.
I added validation that: