Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kds): opt-in insecure skip verify in zone cp client #6991

Merged

Conversation

jakubdyszkiewicz
Copy link
Contributor

Currently, we set insecure skip verify if you do not set CA explicitly in KDS client. This is incorrect as we may want to use CA from the system bundle. This change make use of insecure skip verify as opt in.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@jakubdyszkiewicz jakubdyszkiewicz added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Jun 12, 2023
@jakubdyszkiewicz jakubdyszkiewicz requested review from a team, Automaat and lobkovilya and removed request for a team June 12, 2023 09:18
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz removed the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Jun 12, 2023
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz merged commit 22b6c4c into kumahq:master Jun 13, 2023
3 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/insecure-skip-tls branch June 13, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants