Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-cp): add possibility to configure concurrent reconciliation… #7010

Merged
merged 2 commits into from Jun 13, 2023
Merged

feat(kuma-cp): add possibility to configure concurrent reconciliation… #7010

merged 2 commits into from Jun 13, 2023

Conversation

Automaat
Copy link
Contributor

… of kubernetes resources

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@Automaat
feat(kuma-cp): add possibility to configure concurrent reconciliation…
feee947 
… of kubernetes resources

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat Automaat requested review from a team, michaelbeaumont and jakubdyszkiewicz and removed request for a team June 13, 2023 09:46
@michaelbeaumont michaelbeaumont added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Jun 13, 2023
@Automaat
feat(kuma-cp): add possibility to configure concurrent reconciliation…
b39a372 
… of kubernetes resources

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
michaelbeaumont
michaelbeaumont approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Automaat Automaat merged commit 49b6543 into kumahq:master Jun 13, 2023
3 checks passed
@Automaat Automaat deleted the feat/kube_resources_concurrent_reconciliation branch June 13, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Automaat @michaelbeaumont @jakubdyszkiewicz