Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade go-control-plane #707

Merged
merged 2 commits into from
May 4, 2020
Merged

Conversation

lobkovilya
Copy link
Contributor

Summary

Upgrade go-control-plane up to v0.9.5. This led to upgrading grpc and protobuf. A lot of tests started failing with new protobuf, apparently, new protobuf treats differently empty fields, so error messages also became slightly different.

I pinned protobuf version to v1.3.2 as it was before using

replace github.com/golang/protobuf => github.com/golang/protobuf v1.3.2

@lobkovilya lobkovilya requested a review from a team April 30, 2020 13:07
@subnetmarco
Copy link
Contributor

What would it take to also upgrade protobuf and be done with it?

@lobkovilya lobkovilya force-pushed the feat/upgrade-go-control-plane branch from 9ffae4c to add89af Compare May 1, 2020 11:04
@lobkovilya
Copy link
Contributor Author

lobkovilya commented May 1, 2020

@subnetmarco at first I updated go-control-plane dependency in a wrong way (with -u flag) and that led to updating all other dependencies including protobuf. I updated go-control-plane dependency in a proper way now and we don't need anymore to pin the version.

So that's fine now, we use the same protobuf v.1.3.2 as the latest go-control-plane does.

Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! don't forget about changelog

@lobkovilya lobkovilya force-pushed the feat/upgrade-go-control-plane branch from 23e2023 to 46372ef Compare May 4, 2020 15:59
@lobkovilya lobkovilya merged commit 2641bf8 into master May 4, 2020
@lobkovilya lobkovilya deleted the feat/upgrade-go-control-plane branch July 29, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants