Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xds): named resources (clusters) builders require name #7104

Merged
merged 1 commit into from Jun 26, 2023
Merged

feat(xds): named resources (clusters) builders require name #7104

merged 1 commit into from Jun 26, 2023

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Jun 24, 2023

Defines the cluster name as a required field for the builder constructor function and adds a validation in the final build function to throw an error if the field is blank.
It also removes the name assignation from several configurers. It asserts that the name shall be known when the builder is instantiated.

Checklist prior to review

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 marked this pull request as ready for review June 24, 2023 18:05
@mmorel-35 mmorel-35 requested a review from a team as a code owner June 24, 2023 18:05
@mmorel-35 mmorel-35 requested review from michaelbeaumont and bartsmykla and removed request for a team June 24, 2023 18:05
@mmorel-35 mmorel-35 changed the title feat(xds): named resources (cluster) builders require name feat(xds): named resources (clusters) builders require name Jun 25, 2023
@jakubdyszkiewicz jakubdyszkiewicz merged commit 32d6e52 into kumahq:master Jun 26, 2023
4 checks passed
@mmorel-35 mmorel-35 deleted the issue-2538/cluster branch June 26, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants