New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(xds): named resources (listeners) builders require name #7105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
changed the title
feat(xds): named resources (listener) builders require name
feat(xds): named resources (listeners) builders require name
Jun 25, 2023
mmorel-35
requested review from
Automaat and
bartsmykla
and removed request for
a team
June 25, 2023 09:25
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
bartsmykla
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits, but LGTM overall.
Re. WithName
and WithOverwriteName
I'm open to discussion, as I'm not strongly opinionated about it.
pkg/xds/envoy/listeners/v3/outbound_listener_configurer_test.go
Outdated
Show resolved
Hide resolved
mmorel-35
commented
Jun 28, 2023
pkg/plugins/policies/meshtrafficpermission/plugin/v1alpha1/plugin_test.go
Outdated
Show resolved
Hide resolved
pkg/plugins/policies/meshtrafficpermission/plugin/v1alpha1/plugin_test.go
Outdated
Show resolved
Hide resolved
pkg/plugins/policies/meshtrafficpermission/plugin/v1alpha1/plugin_test.go
Outdated
Show resolved
Hide resolved
pkg/plugins/policies/meshtrafficpermission/plugin/v1alpha1/plugin_test.go
Outdated
Show resolved
Hide resolved
@mmorel-35 thank you for the contribution |
Co-authored-by: Bart Smykla <bartek@smykla.com> Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
bartsmykla
reviewed
Jun 28, 2023
bartsmykla
reviewed
Jun 28, 2023
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines the listener name as a required field for the builder constructor function and adds a validation in the final build function to throw an error if the field is blank.
It defines a default name for inbound and outbound listeners, but a
withName
function allows to define a custom name.It also removes the name assignation from several configurers. It asserts that the name shall be known when the builder is instantiated.
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?