feat(kuma-cp) friendly response in K8s mode #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subnetmarco
suggested changes
May 1, 2020
nickolaev
force-pushed
the
feat/kumactl_apply_k8s
branch
from
3ad8894
to
3623087
Compare
jakubdyszkiewicz
requested changes
May 4, 2020
nickolaev
force-pushed
the
feat/kumactl_apply_k8s
branch
from
3623087
to
ddbcefb
Compare
nickolaev
force-pushed
the
feat/kumactl_apply_k8s
branch
2 times, most recently
from
aac0b71
to
225a075
Compare
jakubdyszkiewicz
approved these changes
May 4, 2020
added 6 commits
May 4, 2020 20:18
When kuma-cp is run in Kubernetes mode, all the changes should happen through `kubectl`. Send an explanation in the response body, so clients (i.e. `kumactl`) can show it to the user. Fixes #165 Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
When kuma-cp sends back 405 on resource Create/Update/Delete, just show the message in the body. This makes the message more user friendly. Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
force-pushed
the
feat/kumactl_apply_k8s
branch
from
225a075
to
20b3c31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When kuma-cp is run in Kubernetes mode, all the changes should happen through
kubectl. Send an explanation in the response body, so clients (i.e.kumactlor the HTTP API) can show it to the user.Full changelog
Issues resolved
Fix #165