Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): add observability to k8s auth cache #7192

Merged

Conversation

jakubdyszkiewicz
Copy link
Contributor

Checklist prior to review

This PR adds missing observability to k8s auth cache.
Additionally we may want to switch to go burrow for other caches (to have bounded cache), however I don't want to do it in this PR.
Prometheus stats counter is in utils, because it will be reused in Kong Mesh.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner July 6, 2023 10:26
@jakubdyszkiewicz jakubdyszkiewicz requested review from slonka and lobkovilya and removed request for a team July 6, 2023 10:26
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubdyszkiewicz jakubdyszkiewicz merged commit 4bda0ea into kumahq:master Jul 7, 2023
3 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/cache-observability branch July 7, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants