Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MeshHealthCheck): allow top level targetRef kind MeshGateway #7194

Merged
merged 1 commit into from Jul 6, 2023
Merged

feat(MeshHealthCheck): allow top level targetRef kind MeshGateway #7194

merged 1 commit into from Jul 6, 2023

Conversation

michaelbeaumont
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner July 6, 2023 11:20
@michaelbeaumont michaelbeaumont requested review from jakubdyszkiewicz and bartsmykla and removed request for a team July 6, 2023 11:20
@michaelbeaumont
feat(MeshHealthCheck): allow top level targetRef kind MeshGateway
38152d0 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont merged commit aacbb67 into kumahq:master Jul 6, 2023
5 checks passed
@michaelbeaumont michaelbeaumont deleted the feat/healthcheck-mgw branch July 6, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@bartsmykla bartsmykla Awaiting requested review from bartsmykla bartsmykla is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaelbeaumont @jakubdyszkiewicz