Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

сhore: update k8s to 1.18 #720

Merged
merged 16 commits into from
May 11, 2020
Merged

сhore: update k8s to 1.18 #720

merged 16 commits into from
May 11, 2020

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented May 5, 2020 •
edited

Summary

Based on https://github.com/Kong/kuma/pull/718

  • update version of client-go
  • update version of minikube and add new target on circleci for k8s 1.18.0
  • update kubectl

@lobkovilya lobkovilya requested a review from a team May 5, 2020 23:23
jakubdyszkiewicz
jakubdyszkiewicz reviewed May 6, 2020
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you go through new imports and double check the naming. I think stuff like v12 should be aliased

.circleci/config.yml Outdated
@@ -443,6 +443,11 @@ jobs:
- run:
name: Install Kubectl
command: make dev/install/kubectl
- run:
name: Install Conntrack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's that? Why we need it? Should we integrate this with our makefiles?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, for some reason on Ubuntu with --vm-driver=None minikube wants conntrack in its path (only for kubernetes 1.18.x). We don't have makefile target that setup minikube (like we have for kind) so I'm not sure we need install/conntrack as target

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it seems we don't need it in makefiles. You can drop a comment here that it is required by minikube with --vm-driver=None

nickolaev
nickolaev reviewed May 6, 2020
View reviewed changes
Makefile
@@ -123,9 +123,9 @@ GOLANGCI_LINT_VERSION := v1.21.0

CI_KUBEBUILDER_VERSION ?= 2.0.0
CI_KIND_VERSION ?= v0.7.0
CI_MINIKUBE_VERSION ?= v1.4.0
CI_MINIKUBE_VERSION ?= v1.9.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that 👍

nickolaev
nickolaev reviewed May 6, 2020
View reviewed changes
Copy link
Contributor

@nickolaev nickolaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase to get the latest KIND additions from me that were merged.
Also, there is K8s 1.18.2 release, please consider it as these are usually bug fix releases and certainly a better idea that x.x.0 initial ones.

@subnetmarco
Copy link
Contributor

subnetmarco commented May 7, 2020 •
edited

@lobkovilya I agree with @nickolaev's statement. The version we are targeting is 1.18.2 at the moment (the latest 1.18.x).

jakubdyszkiewicz
jakubdyszkiewicz approved these changes May 8, 2020
View reviewed changes
.circleci/config.yml Outdated
@@ -443,6 +443,11 @@ jobs:
- run:
name: Install Kubectl
command: make dev/install/kubectl
- run:
name: Install Conntrack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it seems we don't need it in makefiles. You can drop a comment here that it is required by minikube with --vm-driver=None

@lobkovilya lobkovilya changed the base branch from chore/update-go-1.14.2 to master May 11, 2020 01:19
nickolaev
nickolaev approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@nickolaev nickolaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this!

@lobkovilya lobkovilya merged commit 8d726a7 into master May 11, 2020
@nickolaev nickolaev mentioned this pull request May 13, 2020
Closed
@lobkovilya lobkovilya deleted the chore/update-k8s-1.18 branch July 29, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickolaev nickolaev nickolaev approved these changes

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lobkovilya @subnetmarco @nickolaev @jakubdyszkiewicz