chore(*) cleanup after upgrading to go 1.14 #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
approved these changes
May 11, 2020
|
@jakubdyszkiewicz excellent idea. I will use this PR to push the proposed addition |
nickolaev
changed the title
added 7 commits
May 11, 2020 14:11
after e4d31d, the linter does nto finish its job and complains with "WARN [runner] Can't run linter goanalysis_metalinter" and "export data is newer version - update tool". This is described here golangci/golangci-lint#893. The solution is to use newer golangci-lint, which is done here. Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Go 1.14 deprecates BuildNameToCertificate as described here golang/go#37626 Fixing the linter exposes this issue and it's fixed here. Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Also Move the namespace creation to BeforeSuite section in k8s store testing. Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
force-pushed
the
chore/cleanup_after_go14
branch
from
01d70fd
to
2cfa3da
Compare
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After the upgrade to go 1.14 in #718, the golang-ci is actually not completing its run
successfully. Fixing this by bumping its version to 1.26 (latest) uncovers an issue with a
deprecated call
BuildNameToCertificate, which can be omitted.Also run
go mod tidyto cleanup unneeded dependencies.Full changelog
go mod tidyIssues resolved
None