Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kumactl): define User-Agent #7307

Merged
merged 1 commit into from Jul 21, 2023
Merged

feat(kumactl): define User-Agent #7307

merged 1 commit into from Jul 21, 2023

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Jul 19, 2023 •
edited

Defines the User-Agent value kumactl/1.0.0 (Linux; amd64; Kuma/a1f30b4) With

  • 1.0.0 : the version of Kuma,
  • Kuma : the name of the Product
  • a1f30b4 : the short git commit

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- Set userAgent in kumactl #7298
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@mmorel-35 mmorel-35 changed the title feat(kumact): define User-Agent feat(kumactl): define User-Agent Jul 20, 2023
@mmorel-35
Copy link
Contributor Author

Hi @lahabana ,
The Header customization was added but there is no place to check the headers value in the tests suites.
How would you suggest to test this ?

@mmorel-35
feat(kumact): define User-Agent
244a2d7 
Defines the User-Agent value kumactl/1.0.0 (Linux; amd64; Kuma/a1f30b4)
With
* 1.0.0 , the version of Kuma,
* Kuma the name of the Product
* a1f30b4 the short git commit

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 marked this pull request as ready for review July 20, 2023 12:27
@mmorel-35 mmorel-35 requested a review from a team as a code owner July 20, 2023 12:27
@mmorel-35 mmorel-35 requested review from michaelbeaumont and lukidzi and removed request for a team July 20, 2023 12:27
@lahabana
Copy link
Contributor

Looks great thx:

image

@lahabana lahabana merged commit afbf3e5 into kumahq:master Jul 21, 2023
4 checks passed
@mmorel-35 mmorel-35 deleted the issue-7298 branch July 21, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont michaelbeaumont is a code owner automatically assigned from kumahq/kuma-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmorel-35 @lahabana