fix(kuma-cp): order resources for building VIPs #7333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
lukidzi
force-pushed
the
fix/stable-dns-test
branch
from
59dc462
to
d064bc0
Compare
michaelbeaumont
approved these changes
Jul 24, 2023
|
@lobkovilya knows details WRT ordered in the store. It's meant to be used carefully IIRC mostly because of caching |
jakubdyszkiewicz
approved these changes
Jul 25, 2023
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
|
Please reference #7356 instead |
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
lobkovilya
approved these changes
Jul 26, 2023
|
backporting to release-2.3 with action |
|
backporting to release-1.8 with action |
kumahq bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
This was referenced Jul 26, 2023
kumahq bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
lukidzi
pushed a commit
that referenced
this pull request
Jul 26, 2023
lukidzi
pushed a commit
that referenced
this pull request
Jul 26, 2023
lukidzi
pushed a commit
that referenced
this pull request
Jul 26, 2023
lukidzi
pushed a commit
that referenced
this pull request
Jul 26, 2023
lukidzi
pushed a commit
that referenced
this pull request
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
It looks like resources are not ordered; whenever we do a
Listcall, we can get resources in a different order. I've added sorting of the resources to make it stable in case we have a duplicate of the resource and we should use the first in order not randomly.I tried to use
store.ListOrderedbut it seems not implemented formemoryandk8s? Should we implement it on the store level? WDYT?syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?