konvoyctl: use kubectl proxy to connect to Konvoy API Server
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
force-pushed
the
feature/konvoyctl-proxy
branch
5 times, most recently
from
e8a1ec4
to
751b0ab
Compare
yskopets
changed the base branch from
baseline/feature/konvoyctl-proxy
to
feature/unmarshal-rest-resourcelist
jakubdyszkiewicz
approved these changes
Jul 26, 2019
yskopets
force-pushed
the
feature/unmarshal-rest-resourcelist
branch
from
92ef280
to
560a7fc
Compare
yskopets
force-pushed
the
feature/konvoyctl-proxy
branch
from
751b0ab
to
5b97634
Compare
yskopets
changed the base branch from
feature/unmarshal-rest-resourcelist
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
kubectl proxyto connect toKonvoy API Serverkubectl proxybut rather embed it in-process in order to avoid exposing Kubernetes apis onlocalhost:XXXXResourceStoreabstraction to make requests toKonvoy API Server--meshflag tokonvoyctlkonvoyctl get dataplanescan now only list dataplanes per single mesh