Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kds): use hash-suffix for KDS sync #7519

Merged
merged 15 commits into from Sep 19, 2023
Merged

feat(kds): use hash-suffix for KDS sync #7519

merged 15 commits into from Sep 19, 2023

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Aug 15, 2023 •
edited

Depends on #7711

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lobkovilya
feat(kuma-cp): use hash-suffix for KDS sync
450af69 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya mentioned this pull request Sep 7, 2023
Merged
6 tasks
@lobkovilya
Merge branch 'master' into feat/kds-use-hash-suffix
b45d2f9
@lobkovilya
fix e2e tests
aec98f0 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
fix e2e tests
23a5e74 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
fix e2e tests
43f94b4 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
fix e2e tests
9d34634 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
Merge branch 'fix/mt-references-mhr' into feat/kds-use-hash-suffix
aed6c14 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	test/e2e_env/multizone/multizone_suite_test.go
@lobkovilya
resolve targetRef using hash
da27eac 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
handle standalone
ba9fa6d 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya marked this pull request as ready for review September 8, 2023 08:18
@lobkovilya lobkovilya requested a review from a team as a code owner September 8, 2023 08:18
@lobkovilya lobkovilya requested review from Automaat and bartsmykla and removed request for a team September 8, 2023 08:18
@bartsmykla bartsmykla mentioned this pull request Sep 11, 2023
Closed
@lobkovilya lobkovilya merged commit a26933e into kumahq:master Sep 19, 2023
5 checks passed
@lobkovilya lobkovilya deleted the feat/kds-use-hash-suffix branch September 19, 2023 09:36
@lahabana lahabana changed the title feat(kuma-cp): use hash-suffix for KDS sync feat(kds): use hash-suffix for KDS sync Nov 3, 2023
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana left review comments

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

@bartsmykla bartsmykla Awaiting requested review from bartsmykla bartsmykla is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lobkovilya @lahabana @jakubdyszkiewicz