chore(kuma-cp) lock verison of ginkgo #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobkovilya
reviewed
May 21, 2020
| @@ -107,6 +107,7 @@ PROTOC_VERSION := 3.6.1 | |||
| PROTOC_PGV_VERSION := v0.3.0-java.0.20200311152155-ab56c3dd1cf9 | |||
| GOLANG_PROTOBUF_VERSION := v1.3.2 | |||
| GOLANGCI_LINT_VERSION := v1.26.0 | |||
| GINKGO_VERSION := v1.12.0 | |||
There was a problem hiding this comment.
Can we lock the version to v1.12.2?
There was a problem hiding this comment.
We can't because it upgrades github.com/golang/protobuf which breaks the project. I'll let it for a person who will be upgrading dependencies just like we said we will be doing monthly.
nickolaev
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
go geteven without-uflag upgrades Ginkgo version ingo.mod.We don't want automatic upgrades of Ginkgo because it can bring dependencies that break build, therefore I'm locking the version.
Also installing Gomega as a part of
dev/install/ginkgois unnecessary.