feat(kuma-cp) Certs for every inbound #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobkovilya
reviewed
May 25, 2020
| for _, resource := range snapshot.Resources[envoy_types.Secret].Items { | ||
| sec := resource.(*envoy_auth.Secret) | ||
| if envoy_names.IsDpCertResource(sec.Name) { | ||
| secret = sec |
There was a problem hiding this comment.
Is it correct that dataplaneInsight will have expiration time only of the dp cert of the last outbound? Is it okay?
There was a problem hiding this comment.
all certs are generated at the same time, so I'd say - yes
| @@ -44,7 +44,7 @@ func (ds *DataplaneInsight) UpdateCert(generation time.Time, expiration time.Tim | |||
| return err | |||
| } | |||
| ds.MTLS.CertificateExpirationTime = ts | |||
| ds.MTLS.CertificateRegenerations++ | |||
| ds.MTLS.CertificateRegenerations += uint32(certs) | |||
There was a problem hiding this comment.
If certificateRegeneration process happens for all certificates at a time, do we really want to count every certificate separately?
There was a problem hiding this comment.
Yes, because we need to know how many certs were generated
lobkovilya
approved these changes
May 25, 2020
jakubdyszkiewicz
force-pushed
the
feat/cert-for-inbounds
branch
from
9561b83
to
8b4c557
Compare
jakubdyszkiewicz
added a commit
that referenced
this pull request
May 26, 2020
This reverts commit 1b34dab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Until now we Dataplane received only one certificate for their
IdentityService(first service of the inbound). This PR changes this so we generate a certificate for every inbound. This means that you can specify TrafficPermission for the individual inbound.