Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp) allow slash validation so standard K8S tags are supported #762

Merged
merged 1 commit into from
May 22, 2020
Merged

fix(kuma-cp) allow slash validation so standard K8S tags are supported #762

merged 1 commit into from
May 22, 2020

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Allow slash validation so standard K8S tags are supported

Issues resolved

Fix #754

@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team May 22, 2020 12:20
nickolaev
nickolaev approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@nickolaev nickolaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was easy :) We shall merge.

@jakubdyszkiewicz jakubdyszkiewicz merged commit 953734e into master May 22, 2020
@jakubdyszkiewicz jakubdyszkiewicz deleted the fix/validation-slash branch May 22, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickolaev nickolaev nickolaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let / character in tag name
2 participants
@jakubdyszkiewicz @nickolaev