Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kds): experimental event based watchdog #7624

Conversation

jakubdyszkiewicz
Copy link
Contributor

Checklist prior to review

A test of experimental event-based watchdog for KDS.
I tested it manually with E2E test and it looks ok. We want to deploy this on our dev environment to see the perf gain. This might be a default, but for now we want to put it behind a flag.

The idea is instead of querying DB resources every X interval we react on postgres events and only generate snapshot for changed resources. Every Y interval we do a full resync if for some reason we lose the event.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner August 31, 2023 09:06
@jakubdyszkiewicz jakubdyszkiewicz requested review from slonka and Automaat and removed request for a team August 31, 2023 09:06
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits, but lgtm overall

pkg/kds/v2/server/components.go Show resolved Hide resolved
pkg/kds/v2/reconcile/snapshot_generator.go Outdated Show resolved Hide resolved
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Aug 31, 2023
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz removed the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Aug 31, 2023
@jakubdyszkiewicz jakubdyszkiewicz merged commit 4a8b3eb into kumahq:master Aug 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants