Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store): add owner reference to the secrets #7770

Merged
merged 16 commits into from Sep 19, 2023
Merged

feat(store): add owner reference to the secrets #7770

merged 16 commits into from Sep 19, 2023

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Sep 15, 2023 •
edited

based on #7736

closes #3276

you can check parent project PR to see how it works there

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@slonka
feat(store): add owner to secrets
d694f8a 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(store): tmp
20e2bc5 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(store): wire up owner to the signing key manager
d2a6549 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(store): make linter happy
a328e5e 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(store): remove focus
53a0501 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Sep 15, 2023
@slonka
feat(store): make builtin test pass
16228c7 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(store): fix compilation
5fcd352 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(store): fix secrets test
d32ee3a 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(store): make linter happy
d10917f 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(store): reverse the order
bcdae67 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(store): properly convert mesh object and set as owner
c4b4cc5 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(store): make linter happy
246a42a 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(store): rename secrets so async namespace deletion does not caus…
ae669a2 
…e trouble

Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(store): remove unused conversion block
c7d1cba 
Signed-off-by: slonka <slonka@users.noreply.github.com>
slonka
slonka commented Sep 18, 2023
View reviewed changes
pkg/core/ca/manager.go Show resolved Hide resolved
pkg/core/managers/apis/mesh/mesh_manager.go Show resolved Hide resolved
pkg/defaults/mesh.go
}
logger.Info("default Mesh created")
return nil
return mesh, nil
Copy link
Contributor Author

@slonka slonka Sep 18, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to return the mesh so we can hook it up as an owner

pkg/plugins/ca/builtin/manager_test.go Show resolved Hide resolved
pkg/plugins/runtime/k8s/controllers/mesh_defaults_controller_test.go Show resolved Hide resolved
pkg/plugins/secrets/k8s/store_test.go Show resolved Hide resolved
pkg/xds/secrets/secrets_test.go Show resolved Hide resolved
test/e2e_env/kubernetes/gateway/gateway.go Outdated Show resolved Hide resolved
pkg/plugins/secrets/k8s/store.go Outdated Show resolved Hide resolved
@slonka slonka marked this pull request as ready for review September 18, 2023 09:47
@slonka slonka requested a review from a team as a code owner September 18, 2023 09:47
@slonka slonka requested review from michaelbeaumont and Automaat and removed request for a team September 18, 2023 09:47
@slonka
feat(store): revert unwanted change
5c66adc 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(store): add coments from PR
343d872 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka merged commit 0f0b24d into master Sep 19, 2023
5 checks passed
@slonka slonka deleted the add-owners-to-the-secretmanager-new branch September 19, 2023 14:56
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobkovilya lobkovilya lobkovilya left review comments

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Owners to the SecretManager
3 participants
@slonka @michaelbeaumont @lobkovilya