Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kds): allow to delay full resync when ticker #7782

Merged
merged 1 commit into from Sep 18, 2023

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Sep 18, 2023

Checklist prior to review

When zones are reconnecting to the global control plane they might reconnect at the same time. That could cause that ticker responsible for full resync might be processed at the same time. We have introduced an option to delay a full resync by random between 0-FullResyncInterval. First tick will be delayed but after it we are setting it to FullResyncInterval.

  • Link to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi requested a review from a team as a code owner September 18, 2023 13:12
@lukidzi lukidzi requested review from michaelbeaumont and Automaat and removed request for a team September 18, 2023 13:12
@lukidzi lukidzi merged commit 0ea937a into kumahq:master Sep 18, 2023
7 checks passed
@lahabana lahabana changed the title feat(kuma-cp): allow to delay full resync when ticker feat(kds): allow to delay full resync when ticker Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants