Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(insights): fetch external services once #7796

Merged
merged 1 commit into from Sep 20, 2023

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Sep 19, 2023

Checklist prior to review

When calculating insight we are fetching ExternalServices twice. We can fetch them only once and pass to other method.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi requested a review from a team as a code owner September 19, 2023 18:03
@lukidzi lukidzi requested review from slonka and jakubdyszkiewicz and removed request for a team September 19, 2023 18:03
@jakubdyszkiewicz jakubdyszkiewicz merged commit 17d57aa into kumahq:master Sep 20, 2023
7 checks passed
@lahabana lahabana changed the title perf(insight): fetch external services once perf(insights): fetch external services once Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants