Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: openshift owner role #780

Merged
merged 2 commits into from
May 26, 2020
Merged

fix: openshift owner role #780

merged 2 commits into from
May 26, 2020

Conversation

lobkovilya
Copy link
Contributor

Summary

OpenShift requires permission to add finalizers to owners.

Full changelog

  • add dataplanes/finalizers resource to kuma:control-plane clusterrole

Issues resolved

Fix https://github.com/Kong/kuma/issues/772

@lobkovilya lobkovilya requested a review from a team May 26, 2020 14:14
nickolaev
nickolaev approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@nickolaev nickolaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do we have any evidence this solves the issues on OpenShift? If you have a set of logs or an output of a command to attach in the Issue, that can help, as today we do not have a CI for it.

@lobkovilya
Copy link
Contributor Author

I tested it manually on local openshift cluster, unfortunately, I've already stopped it

@lobkovilya lobkovilya merged commit d26da2c into master May 26, 2020
@lobkovilya lobkovilya deleted the fix/openshift-owner-role branch July 29, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickolaev nickolaev nickolaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to create DataplaneInsights
2 participants
@lobkovilya @nickolaev