Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add service-account features to egress and ingress #7864

Merged
merged 1 commit into from Sep 27, 2023

Conversation

lahabana
Copy link
Contributor

Add features that existed for the CP but not ingress/egress:

  • imagePullSecrets (for egress)
  • serviceAccountAnnotations
  • automountServiceAccountToken

Fix #7824

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana lahabana requested a review from a team as a code owner September 25, 2023 19:13
@lahabana lahabana requested review from michaelbeaumont and lukidzi and removed request for a team September 25, 2023 19:13
Add features that existed for the CP but not ingress/egress:

- imagePullSecrets (for egress)
- serviceAccountAnnotations
- automountServiceAccountToken

Fix kumahq#7824

Signed-off-by: Charly Molter <charly.molter@konghq.com>
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need any other tests?

@lahabana
Copy link
Contributor Author

Do we need any other tests?

To test what there's plenty of tests that show that the files are not changed except in our case where we exercise these new flags no?

@lahabana lahabana merged commit 107d388 into kumahq:master Sep 27, 2023
5 checks passed
@lahabana lahabana deleted the fix7824 branch March 29, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make automounting of service accounts configurable for zone ingress and egress
2 participants