Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kds): add user-agent with useful version info #7886

Merged
merged 1 commit into from Sep 27, 2023
Merged

feat(kds): add user-agent with useful version info #7886

merged 1 commit into from Sep 27, 2023

Conversation

lahabana
Copy link
Contributor

This is useful to debug KDS problems with access log on gateways

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana lahabana requested a review from a team as a code owner September 26, 2023 17:03
@lahabana lahabana requested review from michaelbeaumont and jakubdyszkiewicz and removed request for a team September 26, 2023 17:03
@lahabana
feat(kds): add user-agent with useful version info
978b6b5 
This is useful to debug KDS problems with access log on gateways

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana merged commit 01b9990 into kumahq:master Sep 27, 2023
9 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023 •
edited

backporting to release-2.0 with action

backporting to release-2.1 with action
backporting to release-2.3 with action

kumahq bot pushed a commit that referenced this pull request Sep 27, 2023
@lahabana @kumahq
feat(kds): add user-agent with useful version info (#7886)
126915f 
This is useful to debug KDS problems with access log on gateways

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@kumahq kumahq bot mentioned this pull request Sep 27, 2023
Closed
kumahq bot pushed a commit that referenced this pull request Sep 27, 2023
@lahabana @kumahq
feat(kds): add user-agent with useful version info (#7886)
4da7571 
This is useful to debug KDS problems with access log on gateways

Signed-off-by: Charly Molter <charly.molter@konghq.com>
This was referenced Sep 27, 2023
Closed
Closed
kumahq bot pushed a commit that referenced this pull request Sep 27, 2023
@lahabana @kumahq
feat(kds): add user-agent with useful version info (#7886)
3aefa52 
This is useful to debug KDS problems with access log on gateways

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@kumahq kumahq bot mentioned this pull request Sep 27, 2023
Merged
kumahq bot pushed a commit that referenced this pull request Sep 27, 2023
@lahabana @kumahq
feat(kds): add user-agent with useful version info (#7886)
9ad4024 
This is useful to debug KDS problems with access log on gateways

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@kumahq kumahq bot mentioned this pull request Sep 27, 2023
Closed
kumahq bot pushed a commit that referenced this pull request Sep 27, 2023
@lahabana @kumahq
feat(kds): add user-agent with useful version info (#7886)
8480fe1 
This is useful to debug KDS problems with access log on gateways

Signed-off-by: Charly Molter <charly.molter@konghq.com>
lahabana added a commit that referenced this pull request Sep 27, 2023
@kumahq @lahabana
feat(kds): add user-agent with useful version info (backport of #7886) (
793da5a 
#7897)

feat(kds): add user-agent with useful version info (#7886)

This is useful to debug KDS problems with access log on gateways

Signed-off-by: Charly Molter <charly.molter@konghq.com>
Co-authored-by: Charly Molter <charly.molter@konghq.com>
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2023
Merged
@lahabana lahabana deleted the kdsUserAgent branch March 29, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont michaelbeaumont is a code owner automatically assigned from kumahq/kuma-maintainers

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz jakubdyszkiewicz is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lahabana @lukidzi