konvoyctl: support get dataplanes for Control Plane installed outside k8s
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
force-pushed
the
feature/konvoyctl-get-dataplanes-standalone
branch
2 times, most recently
from
6c0b38c
to
9c24fe8
Compare
yskopets
force-pushed
the
feature/konvoyctl-add-standalone-control-plane
branch
from
79ef3aa
to
39eda64
Compare
yskopets
changed the base branch from
feature/konvoyctl-add-standalone-control-plane
to
feature/add-unit-tests-for-konvoyctl-config-control-planes-add-k8s
jakubdyszkiewicz
requested changes
Jul 29, 2019
| if err != nil { | ||
| return nil, errors.Wrapf(err, "Failed to parse API Server URL") | ||
| } | ||
| client := util_http.ClientWithBaseURL(&http.Client{}, baseURL) |
There was a problem hiding this comment.
HTTP Clients should be created with connection and socket timeouts. We don't want user to be stuck on the command when there is a problem with Control Plane API Server.\
https://medium.com/@nate510/don-t-use-go-s-default-http-client-4804cb19f779
| }) | ||
| }) | ||
|
|
||
| type RoundTripperFunc func(*http.Request) (*http.Response, error) |
There was a problem hiding this comment.
Do we need it here?
There was a problem hiding this comment.
No, I will remove it.
jakubdyszkiewicz
approved these changes
Jul 30, 2019
yskopets
force-pushed
the
feature/add-unit-tests-for-konvoyctl-config-control-planes-add-k8s
branch
2 times, most recently
from
acebb61
to
8a16301
Compare
yskopets
force-pushed
the
feature/konvoyctl-get-dataplanes-standalone
branch
from
6903d09
to
e073a25
Compare
yskopets
changed the base branch from
feature/add-unit-tests-for-konvoyctl-config-control-planes-add-k8s
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
get dataplanesfor Control Plane installed outside k8s