Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add possibility to run universal zone cp on kubernetes #7924

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

Automaat
Copy link
Contributor

Fixes: #7129

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • [ x Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Fixes: kumahq#7129
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat Automaat requested a review from a team as a code owner September 29, 2023 13:32
@Automaat Automaat requested review from jakubdyszkiewicz and lobkovilya and removed request for a team September 29, 2023 13:32
@Automaat Automaat changed the title feat(helm): Add possibility to run universal zone cp on kubernetes feat(helm): add possibility to run universal zone cp on kubernetes Sep 29, 2023
Fixes: kumahq#7129
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you also make sure that we don't run HELM webhook for both global and zone universal. Thsoe hook patches namespace and manages CRD which is redundant

@Automaat
Copy link
Contributor Author

Automaat commented Oct 2, 2023

Looks good, can you also make sure that we don't run HELM webhook for both global and zone universal. Thsoe hook patches namespace and manages CRD which is redundant

@jakubdyszkiewicz isn't this achieved by running helm with --skip-crds option. For global, we were suggesting this in docs

@jakubdyszkiewicz
Copy link
Contributor

It's not. Even with --skip-crds HELM would still execute HELM hooks. See pre-* and post-* files

Fixes: kumahq#7129
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
Copy link
Contributor Author

Automaat commented Oct 3, 2023

It's not. Even with --skip-crds HELM would still execute HELM hooks. See pre-* and post-* files

ok, checked and added missing if in two files

@Automaat Automaat merged commit 671b992 into kumahq:master Oct 5, 2023
5 checks passed
@Automaat Automaat deleted the feat/universal-zone-on-k8s-helm branch October 5, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add helm support for running zone universal CP
2 participants