Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add support for controlplane deployment annotations #7959

Merged

Conversation

slavogiez
Copy link
Contributor

@slavogiez slavogiez commented Oct 4, 2023

This adds ability to add annotations on the controlplane deployment.
Not sure if it's the best way to do this. Please also let me know if you'd like to get the same feature on other deployments (ingress, egress, ...)

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@slavogiez slavogiez force-pushed the feat/helm-cp-deployment-annotations branch 4 times, most recently from 854bcd7 to 7f1463a Compare October 4, 2023 12:48
@slavogiez slavogiez force-pushed the feat/helm-cp-deployment-annotations branch 3 times, most recently from 6b4f120 to bcd6841 Compare October 6, 2023 06:53
@slavogiez slavogiez marked this pull request as ready for review October 6, 2023 07:29
@slavogiez slavogiez requested a review from a team as a code owner October 6, 2023 07:29
@slavogiez slavogiez requested review from Automaat and bartsmykla and removed request for a team October 6, 2023 07:29
@slavogiez slavogiez force-pushed the feat/helm-cp-deployment-annotations branch 2 times, most recently from e000dea to e17e37a Compare October 6, 2023 09:00
@michaelbeaumont
Copy link
Contributor

/format /golden_files

slavogiez and others added 2 commits October 9, 2023 08:38
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: slavogiez <stephane.lavogiez@gmail.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@slavogiez slavogiez force-pushed the feat/helm-cp-deployment-annotations branch from d775474 to 89dc5db Compare October 9, 2023 06:38
@slavogiez slavogiez marked this pull request as draft October 9, 2023 06:39
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@michaelbeaumont
Copy link
Contributor

@slavogiez is it ok if we mark this ready as review and merge? Or was there something you wanted to add/change?

@slavogiez slavogiez marked this pull request as ready for review October 13, 2023 06:54
@slavogiez
Copy link
Contributor Author

@slavogiez is it ok if we mark this ready as review and merge? Or was there something you wanted to add/change?

Everything's ok. LGTM!

@michaelbeaumont michaelbeaumont merged commit e80604b into kumahq:master Oct 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants