Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kds): try returning unavailable on app context finish #8050

Merged

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Oct 16, 2023

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- not reported via issue
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? -- if a custom client would connect then we probably could but I don't think people are writing custom kds clients
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka marked this pull request as ready for review October 17, 2023 06:59
@slonka slonka requested a review from a team as a code owner October 17, 2023 06:59
@slonka slonka requested review from michaelbeaumont and Automaat and removed request for a team October 17, 2023 06:59
@slonka slonka merged commit 7b8de47 into kumahq:master Oct 17, 2023
10 checks passed
@lahabana lahabana changed the title fix(shutdown): try returning unavailable on app context finish fix(kds): try returning unavailable on app context finish Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants