Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transparent-proxy): fix --wait flags for iptables legacy #8364

Conversation

bartsmykla
Copy link
Contributor

@bartsmykla bartsmykla commented Nov 14, 2023

iptables docs are murky, but it turns out that flags -w and -W cannot take any argument, but --wait and --wait-interval (longer versions), can take one.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
    • no relevant issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • it won't
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • unit tests updated
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md?
    • there is no need
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)
    • there is no need

@bartsmykla bartsmykla requested a review from a team as a code owner November 14, 2023 11:29
@bartsmykla bartsmykla requested review from Automaat and removed request for a team November 14, 2023 11:29
Docs are murky, but it turns out that flags `-w` and `-W` cannot
take any argument, but `--wait` and `--wait-interval` (longer
versions), can take one.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla force-pushed the fix/install-tproxy-on-iptables-legacy branch from dbc7c6d to dc5135c Compare November 14, 2023 11:30
@bartsmykla bartsmykla enabled auto-merge (squash) November 14, 2023 11:33
@bartsmykla bartsmykla merged commit 2c5fbc3 into kumahq:release-2.5 Nov 14, 2023
6 checks passed
@bartsmykla bartsmykla deleted the fix/install-tproxy-on-iptables-legacy branch November 15, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants