fix(kuma-cp) Ingress improvements #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
nickolaev
approved these changes
Jun 19, 2020
| return nil, err | ||
| } | ||
| return &any.Any{TypeUrl: googleApis + proto.MessageName(pb), Value: buffer.Bytes()}, nil | ||
| } |
There was a problem hiding this comment.
I believe #839 should benefit from this one too. @lobkovilya
| tags := map[string]string{ | ||
| "service": "backend", | ||
| "version": "v1", | ||
| "cloud": "aws", |
There was a problem hiding this comment.
Should we increase the number of tags to have higher chances to get a difference (eventually)?
There was a problem hiding this comment.
The problem was very visible with 100 iterations with those 3 of tags.
lobkovilya
approved these changes
Jun 19, 2020
pkg/util/proto/marshal_any.go
Outdated
| const googleApis = "type.googleapis.com/" | ||
|
|
||
| // When saving Snapshot in SnapshotCache we generate version based on proto.Equal() | ||
| // Therefore we need deterministic way of marshaling Any which is part of the Protobuff on which we execute Equal() |
There was a problem hiding this comment.
Typo: Protobuff -> Protobuf
pkg/util/proto/marshal_any.go
Outdated
| const googleApis = "type.googleapis.com/" | ||
|
|
||
| // When saving Snapshot in SnapshotCache we generate version based on proto.Equal() | ||
| // Therefore we need deterministic way of marshaling Any which is part of the Protobuff on which we execute Equal() |
There was a problem hiding this comment.
Typo: marshaling -> marshalling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While testing and working with Ingress I found a couple of small problems
proto.Equalto send snapshot to Envoy if anything changes. This resulted in sending "the same" Envoy config to Ingress with almost every reconciliation loop (1s by default) even without changes. Snapshot was not stable for two reasonsTcpProxyis marshaled byMarshalAnyand put intoTypedConfig(protobuffs inside protobuffs).MarshalAnyWhen having manylb.tagsinMetadataMatchis not marshaled deterministically. It turned out it can be marshaled deterministically with special settings. I createdutilfor it.EmptyinTypedConfigso our tests pass.generateXDSmethods following the example of the outbound proxy generator.Documentation
Internal stuff only. Nothing to document.