feat(kuma-cp) Support many tags in Ingress #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickolaev
approved these changes
Jun 23, 2020
| } | ||
| if tlsContext != nil { | ||
| pbst, err := proto.MarshalAnyDeterministic(tlsContext) | ||
| // there might be a situation when there are multiple sam tags passed here for example two outbound listeners with the same tags, therefore we need to distinct them. |
There was a problem hiding this comment.
nit: "we need to distinguish between them"
lobkovilya
approved these changes
Jun 23, 2020
pkg/xds/envoy/tls/sni.go
Outdated
| } | ||
|
|
||
| func TagsFromSNI(sni string) map[string]string { | ||
| r := regexp.MustCompile(`(.*)\{(.*)\}`) |
There was a problem hiding this comment.
I overlooked that during my PR, it makes sense to extract regex to global scope
pkg/xds/envoy/types.go
Outdated
| } | ||
|
|
||
| func DistinctTags(tags []Tags) []Tags { | ||
| if len(tags) == 0 { |
There was a problem hiding this comment.
We don't need this check since we iterate over tags in loop
pkg/xds/envoy/tls/sni.go
Outdated
| func SNIFromTags(tags envoy.Tags) string { | ||
| nonServiceTags := tags.WithoutTag(mesh_proto.ServiceTag) | ||
| var pairs []string | ||
| for _, key := range nonServiceTags.Keys() { |
There was a problem hiding this comment.
Can we reuse tags.String() method here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces support for many tag in Ingress - meaning you can apply TrafficRoute like this
or this (when version: 2 is in different cluster)
Documentation
Will be a part of Multi Cluster docs/demo. From user perspective is just a regular TrafficRoute