Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dataplane): ignored listeners with ignored labels in selector #8463

Merged
merged 11 commits into from Dec 5, 2023
Merged

feat(dataplane): ignored listeners with ignored labels in selector #8463

merged 11 commits into from Dec 5, 2023

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Nov 27, 2023 •
edited

Checklist prior to review

Implementation of #8445 MADR.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@jakubdyszkiewicz
feat(Dataplane): introduce ignored listeners
7080bb2 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lahabana
lahabana reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG from a first look but I believe we should do double writes to health as well for backward compatibility (at least the UI relies on health for example)

@jakubdyszkiewicz
Copy link
Contributor Author

True, we should do double writes, but not necessary for the GUI. In the middle of upgrade, old CPs won't recognize state = not ready as unhealthy endpoints

@jakubdyszkiewicz
double writes
05780c4 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz
test(e2e): add e2e test
05ae132 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz
Merge remote-tracking branch 'upstream/master' into feat/ignored-list…
3067494 
…eners

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz marked this pull request as ready for review December 1, 2023 13:15
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner December 1, 2023 13:15
@jakubdyszkiewicz jakubdyszkiewicz requested review from slonka and bartsmykla and removed request for a team December 1, 2023 13:15
@jakubdyszkiewicz
make check
670bd57 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@bartsmykla bartsmykla changed the title feat(Dataplane): ignored listeners with ignored labels in selector feat(dataplane): ignored listeners with ignored labels in selector Dec 2, 2023
@jakubdyszkiewicz
fix double writes
164cceb 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz
Merge remote-tracking branch 'upstream/master' into feat/ignored-list…
b0322da 
…eners

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lobkovilya
lobkovilya reviewed Dec 4, 2023
View reviewed changes
api/mesh/v1alpha1/dataplane.proto Outdated Show resolved Hide resolved
test/e2e_env/kubernetes/kubernetes_suite_test.go Outdated Show resolved Hide resolved
@jakubdyszkiewicz
drop UPPERCASE CONSTATNTS
37d3ab2 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz
Merge remote-tracking branch 'upstream/master' into feat/ignored-list…
09a91bd 
…eners

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz
unignore tests
caf6133 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz
make check
bc9ee28 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz merged commit 2c973d7 into kumahq:master Dec 5, 2023
16 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/ignored-listeners branch December 5, 2023 14:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023 •
edited

backporting to release-2.3 with action

backporting to release-2.1 with action
backporting to release-2.5 with action

This was referenced Dec 5, 2023
Closed
Closed
kumahq bot pushed a commit that referenced this pull request Dec 5, 2023
@jakubdyszkiewicz @kumahq
feat(dataplane): ignored listeners with ignored labels in selector (#…
bc98465 
…8463)

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
kumahq bot pushed a commit that referenced this pull request Dec 5, 2023
@jakubdyszkiewicz @kumahq
feat(dataplane): ignored listeners with ignored labels in selector (#…
769fd41 
…8463)

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@kumahq kumahq bot mentioned this pull request Dec 5, 2023
Closed
kumahq bot pushed a commit that referenced this pull request Dec 5, 2023
@jakubdyszkiewicz @kumahq
feat(dataplane): ignored listeners with ignored labels in selector (#…
46ed9bf 
…8463)

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
kumahq bot pushed a commit that referenced this pull request Dec 5, 2023
@jakubdyszkiewicz @kumahq
feat(dataplane): ignored listeners with ignored labels in selector (#…
87e7eeb 
…8463)

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
This was referenced Dec 5, 2023
Merged
Closed
kumahq bot pushed a commit that referenced this pull request Dec 5, 2023
@jakubdyszkiewicz @kumahq
feat(dataplane): ignored listeners with ignored labels in selector (#…
8299517 
…8463)

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz added a commit that referenced this pull request Dec 5, 2023
@jakubdyszkiewicz
feat(dataplane): ignored listeners with ignored labels in selector (#…
25cab2c 
…8463)

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz added a commit that referenced this pull request Dec 5, 2023
@kumahq @jakubdyszkiewicz
feat(dataplane): ignored listeners with ignored labels in selector (b…
d2ced55 
…ackport of #8463) (#8544)

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Co-authored-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@crunchtime-ali crunchtime-ali mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana left review comments

@lobkovilya lobkovilya lobkovilya approved these changes

@slonka slonka Awaiting requested review from slonka slonka is a code owner automatically assigned from kumahq/kuma-maintainers

@bartsmykla bartsmykla Awaiting requested review from bartsmykla bartsmykla is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakubdyszkiewicz @lahabana @lobkovilya